bancho.js issueshttps://git.cartooncraft.fr/ThePooN/bancho.js/-/issues2020-07-29T22:05:52Zhttps://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/41messsage.user.country is undefined.2020-07-29T22:05:52ZEthan Mitchellmesssage.user.country is undefined.Properties of the class `BanchoUser`, such as `country` return undefined.Properties of the class `BanchoUser`, such as `country` return undefined.https://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/40Docs: Mention that the PM event also handles self-messages2020-09-02T08:38:38ZHugo "ThePooN" Denizartcontact@thepoon.frDocs: Mention that the PM event also handles self-messagesRelease 0.10Hugo "ThePooN" Denizartcontact@thepoon.frHugo "ThePooN" Denizartcontact@thepoon.frhttps://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/39Update rate-limiter2022-10-20T14:56:25ZHugo "ThePooN" Denizartcontact@thepoon.frUpdate rate-limiterRate limits have been made public (even for non-bot users). It's time to update them and make sure it works as intended.Rate limits have been made public (even for non-bot users). It's time to update them and make sure it works as intended.Release 0.10https://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/38TypeScript typings?2020-07-22T12:57:24Zminhducsun2002TypeScript typings?Using bancho.js in TS projects is currently not possible due to missing typing declaration.Using bancho.js in TS projects is currently not possible due to missing typing declaration.https://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/36Memory leaks2020-06-05T14:53:14ZHugo "ThePooN" Denizartcontact@thepoon.frMemory leaksIn current releases, with bancho.js used in certain scenarios, memory leaks occur, especially under heavy usage such as Nathanael's (joining and watching all public channels).
Investigation results are tracked on the following snippet: ...In current releases, with bancho.js used in certain scenarios, memory leaks occur, especially under heavy usage such as Nathanael's (joining and watching all public channels).
Investigation results are tracked on the following snippet: https://git.cartooncraft.fr/ThePooN/bancho.js/snippets/9https://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/35Investigate updateSettings() no longer working in #mp_54318662 (AGTS2019/refe...2019-11-01T15:35:57ZHugo "ThePooN" Denizartcontact@thepoon.frInvestigate updateSettings() no longer working in #mp_54318662 (AGTS2019/referee-helper)Hugo "ThePooN" Denizartcontact@thepoon.frHugo "ThePooN" Denizartcontact@thepoon.frhttps://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/34playerJoined event broken in TeamVs lobbies2018-06-11T07:35:08ZCoryplayerJoined event broken in TeamVs lobbiesReproducible as follows:
Insert the following line right before the playerJoined listener in the multiplayer rotation example:
```lobby.setSettings(Banchojs.BanchoLobbyTeamModes.TeamVs, Banchojs.BanchoLobbyWinConditions.Score);```
For...Reproducible as follows:
Insert the following line right before the playerJoined listener in the multiplayer rotation example:
```lobby.setSettings(Banchojs.BanchoLobbyTeamModes.TeamVs, Banchojs.BanchoLobbyWinConditions.Score);```
For the exact code that I ran, see this paste: https://pastebin.com/qx9PXZci
Result:
Upon joining the room, the "playerJoined" callback is never run, so I am not made the host.
Leaving the room results in an error. Full log:
```
cor@c ~/Desktop/bancho_test $ node test.js
We're online!
Lobby created! Name: Multiplayer rotator ggz5i, password: wvelg
Multiplayer link: https://osu.ppy.sh/mp/43248956
(node:26389) UnhandledPromiseRejectionWarning: TypeError: Cannot add property undefined, object is not extensible
at getPlayerByName.then (/home/cor/Desktop/bancho_test/node_modules/bancho.js/lib/Multiplayer/BanchoLobby.js:213:47)
at process._tickCallback (internal/process/next_tick.js:68:7)
(node:26389) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:26389) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
^CClosing lobby and disconnecting...
```
However, we can change the above line to:
```lobby.setSettings(Banchojs.BanchoLobbyTeamModes.HeadToHead, Banchojs.BanchoLobbyWinConditions.Score);```
Everything then works as expected, with no issues.
Run on Linux Mint 18.3, node version v10.4.0https://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/33Specify IRC password in README2018-06-11T08:59:48ZHugo "ThePooN" Denizartcontact@thepoon.frSpecify IRC password in READMEHugo "ThePooN" Denizartcontact@thepoon.frHugo "ThePooN" Denizartcontact@thepoon.frhttps://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/32Testing implementation of BanchoChannel2020-05-30T14:20:38ZHugo "ThePooN" Denizartcontact@thepoon.frTesting implementation of BanchoChannelThat could be useful to test events and regexes with fake BanchoBot messages. Might require some refactoring here and there, considering this lib wasn't always designed with testing in mind...That could be useful to test events and regexes with fake BanchoBot messages. Might require some refactoring here and there, considering this lib wasn't always designed with testing in mind...https://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/31Player creation should be handled synchronously2023-11-22T18:14:47ZHugo "ThePooN" Denizartcontact@thepoon.frPlayer creation should be handled synchronouslyObserved in a multiplayer a few weeks ago: errors would be fired because of multiple BanchoLobbyPlayer objects created for the same lobby and actual player. The reason was: there were 2 events fired rapidly about a player unknown before,...Observed in a multiplayer a few weeks ago: errors would be fired because of multiple BanchoLobbyPlayer objects created for the same lobby and actual player. The reason was: there were 2 events fired rapidly about a player unknown before, the second one being fired before the first player object was created from their nickname (thus making it async).
Solution: make creation of player objects synchronous.
I have a working patch, but it needs optimization and shit ton of testing.Release 0.9.0Hugo "ThePooN" Denizartcontact@thepoon.frHugo "ThePooN" Denizartcontact@thepoon.frhttps://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/30Improve BanchoMods2018-03-29T12:04:53ZHugo "ThePooN" Denizartcontact@thepoon.frImprove BanchoModsAs reported by Maot on Discord, we should be able to convert bit flags to mods and vice-versa.
Also the documentation for that class is... awful, and actually somewhat wrong.As reported by Maot on Discord, we should be able to convert bit flags to mods and vice-versa.
Also the documentation for that class is... awful, and actually somewhat wrong.Release 1.0.0Hugo "ThePooN" Denizartcontact@thepoon.frHugo "ThePooN" Denizartcontact@thepoon.frhttps://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/28BanchoLobby: fire get_match API request2018-03-28T23:01:25ZHugo "ThePooN" Denizartcontact@thepoon.frBanchoLobby: fire get_match API requestRelease 1.0.0Hugo "ThePooN" Denizartcontact@thepoon.frHugo "ThePooN" Denizartcontact@thepoon.frhttps://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/27BanchoUser: BanchoBot !stats command support2018-02-27T22:22:39ZHugo "ThePooN" Denizartcontact@thepoon.frBanchoUser: BanchoBot !stats command supportRelease 1.0.0Hugo "ThePooN" Denizartcontact@thepoon.frHugo "ThePooN" Denizartcontact@thepoon.frhttps://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/26BanchoUser: BanchoBot !where command support2018-02-27T21:00:22ZHugo "ThePooN" Denizartcontact@thepoon.frBanchoUser: BanchoBot !where command supportRelease 1.0.0Hugo "ThePooN" Denizartcontact@thepoon.frHugo "ThePooN" Denizartcontact@thepoon.frhttps://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/25Add multiplayer scores sorting2018-06-20T19:11:23ZHugo "ThePooN" Denizartcontact@thepoon.frAdd multiplayer scores sortingbancho.js should be able to sort the scores of each player at the end of the map, just like Bancho/the osu! client does.
If in TeamVS, rankings should be made by teams and sum of their players scores (fails count for 0).
If in 1v1 scen...bancho.js should be able to sort the scores of each player at the end of the map, just like Bancho/the osu! client does.
If in TeamVS, rankings should be made by teams and sum of their players scores (fails count for 0).
If in 1v1 scenario, rankings should be sorted first by pass/fail, then by score.
I'm not really sure what the data structure of all of that would be, discussion is open for that.Release 0.9.0Hugo "ThePooN" Denizartcontact@thepoon.frHugo "ThePooN" Denizartcontact@thepoon.frhttps://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/24!mp mods with enum values support2018-05-24T17:19:43ZHugo "ThePooN" Denizartcontact@thepoon.fr!mp mods with enum values supportWill make setting any mod in multiplayer lobbies possible.
Currently waiting on a Bancho restart for this functionality to be deployed.Will make setting any mod in multiplayer lobbies possible.
Currently waiting on a Bancho restart for this functionality to be deployed.Release 1.0.0Hugo "ThePooN" Denizartcontact@thepoon.frHugo "ThePooN" Denizartcontact@thepoon.frhttps://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/23Customizable rate limits2018-02-28T00:22:41ZHugo "ThePooN" Denizartcontact@thepoon.frCustomizable rate limitsAdding more parameters to the BanchoClient constructor will start to be... dodgy. Will likely need an overhaul on the BanchoClient constructor.Adding more parameters to the BanchoClient constructor will start to be... dodgy. Will likely need an overhaul on the BanchoClient constructor.Release 1.0.0Hugo "ThePooN" Denizartcontact@thepoon.frHugo "ThePooN" Denizartcontact@thepoon.frhttps://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/22Missing doc for the main class2018-01-04T23:30:35ZHugo "ThePooN" Denizartcontact@thepoon.frMissing doc for the main classhttps://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/21Fetch multiplayer from API in BanchoLobby2017-12-30T10:49:49ZHugo "ThePooN" Denizartcontact@thepoon.frFetch multiplayer from API in BanchoLobbyhttps://git.cartooncraft.fr/ThePooN/bancho.js/-/issues/20Rate limiting for officially-recognized chat bots2017-12-30T10:20:46ZHugo "ThePooN" Denizartcontact@thepoon.frRate limiting for officially-recognized chat botsEvery osu! account has chat rate limits, but they aren't known.
Officially-recognized chat bots on osu! have higher and known rate limits that we can include in the library.Every osu! account has chat rate limits, but they aren't known.
Officially-recognized chat bots on osu! have higher and known rate limits that we can include in the library.Release v0.6.0